On Tue, May 24, 2022 at 1:17 PM Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> To match the cleanup of tests/xfs
>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> tests/shared/002 | 7 ++++---
> tests/shared/298 | 22 +++++++++++-----------
> 2 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/tests/shared/002 b/tests/shared/002
> index d99539c9..0a92dcc2 100755
> --- a/tests/shared/002
> +++ b/tests/shared/002
> @@ -15,12 +15,13 @@
> . ./common/preamble
> _begin_fstest auto metadata quick log
>
> -# Override the default cleanup function.
> -_cleanup()
> +_dmflakey_cleanup()
> {
> + _unmount_flakey
> _cleanup_flakey
Wait a minute, why was _unmount_flakey() added here?
I see that most dmflakey cleaners do not call unmount_flakey
and it could be for a good reason.
_cleanup_flakey already doesn umount only after doing:
_cleanup_flakey()
{
# If dmsetup load fails then we need to make sure to do resume here
# otherwise the umount will hang
Thanks,
Amir.
