Re: [PATCH 7/8] fstests: Set up BUS trap for tests by default

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, May 24, 2022 at 11:08 AM Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> About 160 individual tests re-register the cleanup trap just to have
> it run on a BUS error signal. Just add the BUS signal to the default
> set of traps initialised by _register_cleanup() and get rid of these
> extra registrations.
>
> This was mostly done with this script:
>
> $ for f in `git grep -l "register_cleanup.*BUS"` ; do
> > sed -i -e '/_register_cleanup "_cleanup" BUS/,+1d'
> > done
>
> With a small number of non-matching conversions done by hand.
>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  common/preamble   | 4 ++--
>  tests/ext4/023    | 2 --
>  tests/generic/161 | 2 --
>  tests/generic/162 | 2 --
>  tests/generic/163 | 2 --
>  tests/generic/164 | 2 --
>  tests/generic/165 | 2 --
>  tests/generic/166 | 2 --
>  tests/generic/167 | 2 --
>  tests/generic/168 | 2 --
>  tests/generic/170 | 2 --
>  tests/generic/247 | 2 --
>  tests/generic/333 | 2 --
>  tests/generic/334 | 2 --
>  tests/generic/349 | 2 --
>  tests/generic/350 | 2 --
>  tests/generic/351 | 2 --
>  tests/generic/356 | 2 --
>  tests/generic/357 | 2 --
>  tests/generic/358 | 2 --
>  tests/generic/359 | 2 --
>  tests/generic/372 | 2 --
>  tests/generic/373 | 2 --
>  tests/generic/374 | 2 --
>  tests/generic/414 | 2 --
>  tests/generic/425 | 2 --
>  tests/generic/553 | 2 --
>  tests/generic/554 | 2 --
>  tests/generic/564 | 2 --
>  tests/generic/565 | 2 --
>  tests/generic/670 | 2 --
>  tests/generic/671 | 2 --
>  tests/generic/672 | 2 --
>  tests/xfs/017     | 2 --
>  tests/xfs/138     | 2 --
>  tests/xfs/162     | 2 --
>  tests/xfs/262     | 2 --
>  tests/xfs/280     | 2 --
>  tests/xfs/285     | 2 --
>  tests/xfs/286     | 2 --
>  tests/xfs/349     | 2 --
>  tests/xfs/350     | 2 --
>  tests/xfs/351     | 2 --
>  tests/xfs/352     | 2 --
>  tests/xfs/353     | 2 --
>  tests/xfs/354     | 2 --
>  tests/xfs/355     | 2 --
>  tests/xfs/356     | 2 --
>  tests/xfs/357     | 2 --
>  tests/xfs/358     | 2 --
>  tests/xfs/359     | 2 --
>  tests/xfs/360     | 2 --
>  tests/xfs/361     | 2 --
>  tests/xfs/362     | 2 --
>  tests/xfs/363     | 2 --
>  tests/xfs/364     | 2 --
>  tests/xfs/365     | 2 --
>  tests/xfs/366     | 2 --
>  tests/xfs/367     | 2 --
>  tests/xfs/368     | 2 --
>  tests/xfs/369     | 2 --
>  tests/xfs/370     | 2 --
>  tests/xfs/371     | 2 --
>  tests/xfs/372     | 2 --
>  tests/xfs/373     | 2 --
>  tests/xfs/374     | 2 --
>  tests/xfs/375     | 2 --
>  tests/xfs/376     | 2 --
>  tests/xfs/377     | 2 --
>  tests/xfs/378     | 2 --
>  tests/xfs/379     | 2 --
>  tests/xfs/380     | 2 --
>  tests/xfs/381     | 2 --
>  tests/xfs/382     | 2 --
>  tests/xfs/383     | 2 --
>  tests/xfs/384     | 2 --
>  tests/xfs/385     | 2 --
>  tests/xfs/386     | 2 --
>  tests/xfs/387     | 2 --
>  tests/xfs/388     | 2 --
>  tests/xfs/389     | 2 --
>  tests/xfs/390     | 2 --
>  tests/xfs/391     | 2 --
>  tests/xfs/392     | 2 --
>  tests/xfs/393     | 2 --
>  tests/xfs/394     | 2 --
>  tests/xfs/395     | 2 --
>  tests/xfs/396     | 2 --
>  tests/xfs/397     | 2 --
>  tests/xfs/398     | 2 --
>  tests/xfs/399     | 2 --
>  tests/xfs/400     | 2 --
>  tests/xfs/401     | 2 --
>  tests/xfs/402     | 2 --
>  tests/xfs/403     | 2 --
>  tests/xfs/404     | 2 --
>  tests/xfs/405     | 2 --
>  tests/xfs/406     | 2 --
>  tests/xfs/407     | 2 --
>  tests/xfs/408     | 2 --
>  tests/xfs/409     | 2 --
>  tests/xfs/410     | 2 --
>  tests/xfs/411     | 2 --
>  tests/xfs/412     | 2 --
>  tests/xfs/413     | 2 --
>  tests/xfs/414     | 2 --
>  tests/xfs/415     | 2 --
>  tests/xfs/416     | 2 --
>  tests/xfs/417     | 2 --
>  tests/xfs/418     | 2 --
>  tests/xfs/422     | 2 --
>  tests/xfs/423     | 2 --
>  tests/xfs/425     | 2 --
>  tests/xfs/426     | 2 --
>  tests/xfs/427     | 2 --
>  tests/xfs/428     | 2 --
>  tests/xfs/429     | 2 --
>  tests/xfs/430     | 2 --
>  tests/xfs/444     | 2 --
>  tests/xfs/453     | 2 --
>  tests/xfs/454     | 2 --
>  tests/xfs/455     | 2 --
>  tests/xfs/456     | 2 --
>  tests/xfs/457     | 2 --
>  tests/xfs/458     | 2 --
>  tests/xfs/459     | 2 --
>  tests/xfs/460     | 2 --
>  tests/xfs/461     | 2 --
>  tests/xfs/462     | 2 --
>  tests/xfs/463     | 2 --
>  tests/xfs/464     | 2 --
>  tests/xfs/465     | 2 --
>  tests/xfs/466     | 2 --
>  tests/xfs/467     | 2 --
>  tests/xfs/468     | 2 --
>  tests/xfs/469     | 2 --
>  tests/xfs/470     | 2 --
>  tests/xfs/471     | 2 --
>  tests/xfs/472     | 2 --
>  tests/xfs/473     | 2 --
>  tests/xfs/474     | 2 --
>  tests/xfs/475     | 2 --
>  tests/xfs/476     | 2 --
>  tests/xfs/477     | 2 --
>  tests/xfs/478     | 2 --
>  tests/xfs/479     | 2 --
>  tests/xfs/480     | 2 --
>  tests/xfs/481     | 2 --
>  tests/xfs/482     | 2 --
>  tests/xfs/483     | 2 --
>  tests/xfs/484     | 2 --
>  tests/xfs/485     | 2 --
>  tests/xfs/486     | 2 --
>  tests/xfs/487     | 2 --
>  tests/xfs/488     | 2 --
>  tests/xfs/489     | 2 --
>  tests/xfs/495     | 2 --
>  tests/xfs/496     | 2 --
>  tests/xfs/497     | 2 --
>  tests/xfs/498     | 2 --
>  tests/xfs/499     | 2 --
>  tests/xfs/503     | 2 +-
>  tests/xfs/507     | 2 +-
>  tests/xfs/517     | 2 +-
>  164 files changed, 5 insertions(+), 325 deletions(-)
>

Nice cleanup!

Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>

Thanks,
Amir.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux