Re: [PATCH] tools/mkgroupfile: help the cases of group.list in number order

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sat, May 21, 2022 at 01:43:49PM +0800, Zorro Lang wrote:
> The mkgroupfile doesn't sort cases in number order, that cause
> fstests' ./new script can't find a proper number which isn't taken.
> The unsorted case number might cause more problems, so fix it.

Yet more reason for these group lists to die and get replaced with a
common generation function.

> Fixes: 441606d28681 ("fstests: faster group file creation")
> Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx>
> ---
> 
> Hi,
> 
> If you'd like to fix this issue seperately, I can merge this patch with Dave's
> "[PATCH 04/12] fstests: fix group list generation for whacky test names"
> together.

It needs documentation updates, too. I had no idea that the group
list files were used by the new script or that there was a
requirement for them to be sorted into numerical order.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux