On Mon, May 16, 2022 at 08:26:18AM -0700, Darrick J. Wong wrote:
> On Mon, May 16, 2022 at 04:08:05PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> >
> > Quota warning code has been removed from the upstream kernel and now
> > returns -EINVAL errors. Seeing as we can't set warnings anymore and
> > they have always been non-functional in the kernel, just remove the
> > calls to set warnings filter those errors out so those tests pass
> > again.
> >
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > ---
> > tests/xfs/050 | 9 ---------
> > tests/xfs/153 | 9 ---------
> > tests/xfs/299 | 9 ---------
> > 3 files changed, 27 deletions(-)
> >
> > diff --git a/tests/xfs/050 b/tests/xfs/050
> > index 1847611b..2220e470 100755
> > --- a/tests/xfs/050
> > +++ b/tests/xfs/050
> > @@ -84,9 +84,6 @@ _exercise()
> > _qsetup $1
> >
> > echo "Using type=$type id=$id" >>$seqres.full
> > -
> > - $XFS_QUOTA_PROG -x -c "warn -$type 65535 -d" $SCRATCH_DEV
> > -
> > echo
> > echo "*** report no quota settings" | tee -a $seqres.full
> > $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \
> > @@ -113,7 +110,6 @@ _exercise()
> > _file_as_id $SCRATCH_MNT/softie3 $id $type 1024 0
> > _file_as_id $SCRATCH_MNT/softie4 $id $type 1024 0
> > _qmount
> > - $XFS_QUOTA_PROG -x -c "warn -i -$type 0 $id" $SCRATCH_DEV
>
> I don't think we can revert this line from commit e5bbd47e
> ("xfs/{050,299}: clear quota warnings in between checks") because any
> kernel released in the past two years will increment the warning
> counter, and not resetting it to zero between tests means the golden
> output will break.
That's a feature, not a bug. i.e. it tells the people running the
tests that there are fixes they need to backport to the kernel they
are testing. Otherwise the moment a user sets warning limits they
will end up with a broken system.
If we want to make sure distros and LTS kernels backport fixes for
this issue, this is the way to make sure their QE/test environments
notice that these is something that needs fixing...
> We could, however, use more sed magic to force the warning counts in the
> repquota output to be zero, which (I think) enables these changes to
> move forward.
I think that's less good that the situation as it doesn't tell
anyone they are running a kernel with broken quota functionality
that needs fixing....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
