On Mon, May 9, 2022 at 1:15 PM David Disseldorp <ddiss@xxxxxxx> wrote:
>
> On Tue, 3 May 2022 11:57:49 +0100, fdmanana@xxxxxxxxxx wrote:
>
> > From: Filipe Manana <fdmanana@xxxxxxxx>
> >
> > Test that if we fsync a directory, create a symlink inside it, rename
> > the symlink, fsync again the directory and then power fail, after the
> > filesystem is mounted again, the symlink exists with the new name and
> > it has the correct content.
> >
> > This currently fails on btrfs, because the symlink ends up empty (which
> > is illegal on Linux), but it is fixed by kernel commit:
> >
> > d0e64a981fd841 ("btrfs: always log symlinks in full mode")
> >
> > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
>
> This looks fine and works for me.
> Reviewed-by: David Disseldorp <ddiss@xxxxxxx>
>
> ...
> > +mkdir $SCRATCH_MNT/testdir
>
> nit: It's worth quoting the variable here (and elsewhere). That said, I
> highly doubt anyone is using a SCRATCH_MNT with a space in it, so it
> should be okay as is.
Indeed.
I'll send an updated version later.
Thanks David.
>
> Cheers, David
