On Wed, Apr 27, 2022 at 04:05:40PM +0800, Zorro Lang wrote: > > "The DAX code currently only supports files with a block size equal to your > kernel's PAGE_SIZE" [1], so I suppose any cases with smaller blocksize (< pagesize) > should "_exclude_scratch_mount_option dax". > > And if this supposition is right, we'd better do "skipping dax testing if blocksize > is less than pagesize" in a common helper. Good news is we have _scratch_mkfs_blocksized. > So how about do: > if [ $blocksize < $pagesize ];then > _exclude_scratch_mount_option dax > fi > in _scratch_mkfs_blocksized? then let ext4/054 and ext4/055 turn to use _scratch_mkfs_blocksized. That's a good thing to and it would work for ext4/054 and ext/022 (which already uses "_exclude_scratch_mount_option dax" and "_scratch_mkfs"). However, a number of other tests, including ext4/055 and ext4/035 need to give additional parameters to mfks, such as "-O quota" or "-E resize=262144". So _scratch_mkfs_blocksized isn't always going to work for tests in ext4/* where we often are passing ext4-specific mkfs options to mkfs.ext4. So I can add your suggestion to _scratch_mkfs_blocksized, and use that for ext4/054, but it's not going to be a solution for ext4/055. Cheers, - Ted
