On Mon, Apr 25, 2022 at 12:31 PM libaokun (A) <libaokun1@xxxxxxxxxx> wrote:
>
> 在 2022/4/24 20:02, Amir Goldstein 写道:
>
> On Sun, Apr 24, 2022 at 2:21 PM Baokun Li <libaokun1@xxxxxxxxxx> wrote:
>
> xfstests support overlay+tmpfs
>
> Thanks for this improvement.
> Can you please share the results of ./check -overlay -g auto ?
>
> How many tests ran? notran? failed?
>
> Best if you have those numbers compared to
> overlay+(already supported base fs)
>
> All right, I'll share it after the adaptation is completed.
>
> ```local.config.example
> export FSTYP=tmpfs
> export TEST_DEV=tmpfs_test
> export TEST_DIR=/tmp/test
> export TEST_FS_MOUNT_OPTS="-t tmpfs"
> export SCRATCH_DEV=tmpfs_scratch
> export SCRATCH_MNT=/tmp/scratch
> export MOUNT_OPTIONS="-t tmpfs"
>
> These mount options for tmpfs are very awkward.
> Please fix _overlay_base_mount to use -t $OVL_BASE_FSTYP
> like _test_mount() and _try_scratch_mount() do
>
> Could you be more specific?
--- a/common/overlay
+++ b/common/overlay
@@ -81,7 +81,7 @@ _overlay_base_mount()
return 1
fi
- _mount $* $dev $mnt
+ _mount -t $OVL_BASE_FSTYP $* $dev $mnt
_idmapped_mount $dev $mnt
}
Untested.
Thanks,
Amir.
