On Thu, Apr 21, 2022 at 10:18 AM Christoph Hellwig <hch@xxxxxx> wrote: > > On Thu, Apr 21, 2022 at 09:05:13AM +0200, Christian Brauner wrote: > > I'd like to avoid that. The testsuite tests a lot of core vfs > > functionality - completely indepenent of idmapped mounts which is why I > > should rename it - that isn't covered anwywhere else in xfstests. > > It also contains various regressions tests for core vfs work. > > Let's keep it in a single repo which will guarantee us that it will be > > run as part of xfstests. > > Yeah, that unionmount testsuite is something no casual users will > run as it requires way too much effort to be usable. Please elaborate. Quoting from README.overlay: To enable running unionmount testsuite, clone the git repository from: https://github.com/amir73il/unionmount-testsuite.git under the xfstests src directory, or set the environment variable UNIONMOUNT_TESTSUITE to the local path where the repository was cloned. Is that what you are referring to by "way too much effort to be usable"? To be clear, I too am in favor of keeping unionmount testsuite in separate repo and keeping idmapped-mounts inside xfstests. Just puzzled about your comment. Thanks, Amir.
