On 19.04.22 г. 15:47 ч., Nikolay Borisov wrote:
On 18.04.22 г. 10:54 ч., Chung-Chiang Cheng wrote:
Compression and nodatacow are mutually exclusive. Besides ioctl, there
is another way to setting compression via xattrs, and shouldn't produce
invalid combinations.
Signed-off-by: Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx>
---
tests/btrfs/264 | 76 +++++++++++++++++++++++++++++++++++++++++++++
tests/btrfs/264.out | 15 +++++++++
2 files changed, 91 insertions(+)
create mode 100755 tests/btrfs/264
create mode 100644 tests/btrfs/264.out
diff --git a/tests/btrfs/264 b/tests/btrfs/264
new file mode 100755
index 000000000000..42bfcd4f93a0
--- /dev/null
+++ b/tests/btrfs/264
@@ -0,0 +1,76 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2022 Synology Inc. All Rights Reserved.
+#
+# FS QA Test No. 264
+#
+# Compression and nodatacow are mutually exclusive. Besides ioctl, there
+# is another way to setting compression via xattrs, and shouldn't
produce
+# invalid combinations.
+#
+# To prevent mix any compression-related options with nodatacow,
FS_NOCOMP_FL
+# is also rejected by ioctl as well as FS_COMPR_FL on nodatacow
files. To
+# align with it, no and none are also unacceptable in this test.
+#
+# The regression is fixed by a patch with the following subject:
+# btrfs: do not allow compression on nodatacow files
+#
+. ./common/preamble
+_begin_fstest auto quick compress attr
+
+# Import common functions.
+. ./common/filter
+. ./common/attr
+
+# real QA test starts here
+
+_supported_fs btrfs
+_require_scratch
+_require_chattr C
+_require_chattr c
+
+_scratch_mkfs >>$seqres.full 2>&1
+_scratch_mount
+
+#
+# DATACOW
+#
+test_file="$SCRATCH_MNT/foo"
+touch "$test_file"
+$CHATTR_PROG -C "$test_file"
+$LSATTR_PROG -l "$test_file" | _filter_scratch
+
+$SETFATTR_PROG -n "btrfs.compression" -v zlib "$test_file" |&
_filter_scratch
In my testing setfattr doesn't produce any output, so why the
_filter_scratch ?
nit: Ah right, that applies to those setfattr calls that are expected to
fail when doing the nodatacow ops. So perhaps you could only do |& on
the setfattr calls which are expected to fail.
<snip>
SO the main thing which remains to fix is calling the _filter_spaces to
ensure the test succeeds.
