On Mon, Apr 18, 2022 at 6:19 PM Theodore Ts'o <tytso@xxxxxxx> wrote:
>
> On Mon, Apr 18, 2022 at 08:26:33AM +0300, Amir Goldstein wrote:
> > >
> > > The _fixed_by_kernel_commit is fine, just not all cases for kernel patch,
> > > some of them cover patch from userspace packages. So you might change it
> > > to _fixed_by_upstream_commit, then let its arguments point out the commit
> > > from which upstream project.
> >
> > I thought about it too and I agree we should have _fixed_by_upstream_commit
> > In fact, LTP tests are annotated like this: {"linux-git", "8edc6e1688fc"}.
>
> Sometimes there will be a different fix for stable kernels because the
> "proper" fix in upstream is too risky / dangerous / involved. So it
> might be useful to specify multiple commits.
>
multiple hints are supported, see:
tests/overlay/074:_fixed_by_kernel_commit 144da23beab8 \
tests/overlay/074 "ovl: return required buffer size for file handles"
tests/overlay/074:_fixed_by_kernel_commit 9aafc1b01873 \
tests/overlay/074 "ovl: potential crash in ovl_fid_to_fh()"
> > But I decided that even if and when we add _fixed_by_upstream_commit
> > we had better leave the wrapper _fixed_by_kernel_commit for brevity
> > because it is by far going to be the most used annotation.
> > I can add this helper now or it could be added later.
>
> Maybe allow multiple _fixed_by_kernel_commit where the default is
> upstream, and then other git trees can be specified? e.g.:
>
> _fixed_by_kernel_commit 8edc6e1688fc
> _fixed_by_kernel_commit deadbeef1234 linux-5.4
> _fixed_by_kernel_commit f00dfeed5678 linux-5.10
>
All the args are just free text printed as hint, so you could
write it as:
_fixed_by_kernel_commit 8edc6e1688fc \
"fanotify: fix notification of groups with inode & mount marks"
_fixed_by_kernel_commit deadbeef1234 linux-5.4 \
"[5.4 backport] fanotify: fix notification of groups with inode
& mount marks"
Which results in:
HINT: You _MAY_ be missing kernel fix:
8edc6e1688fc fanotify: fix notification of groups with inode & mount marks
HINT: You _MAY_ be missing kernel fix:
deadbeef1234 [5.4 backport] fanotify: fix notification of groups
with inode & mount marks
Thanks,
Amir.
