> Hi Darrick, that's another story, you don't need to worry about that in this case :) > I'd like to ack this patch, but hope to move it from generic/ to shared/ . Maybe > Eryu can help to move it, or I can do that after I get the push permission. > > The reason why I intend moving it to shared is: > Although we are trying to get rid of tests/shared/, but the tests/shared/ still help to > remind us what cases are still not real generic cases. We'll try to help all shared > cases to be generic. When the time is ready, I'd like to move this case to generic/ > and change _supported_fs from "xfs btrfs ext4" to "generic". > Sorry, but I have to object to this move. I do not think that is what tests/shared should be used for. My preferences are: 1. _suppoted_fs generic && _require_xfs_io_command "finsert" 2. _suppoted_fs generic 3. _supported_fs xfs btrfs ext4 (without moving to tests/shared) Thanks, Amir.
