[PATCH] common/attr: reduce MAX_ATTRVAL_SIZE for NFS

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



When testing against an NFS export backed by a Btrfs filesystem,
generic/020 may fail, e.g.

  --- /xfstests/tests/generic/020.out
  +++ /xfstests/results/generic/020.out.bad
  @@ -47,9 +47,13 @@
   user.snrub="fish2\012"

   *** really long value
  -0000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  -*
  -ATTRSIZE
  +attr_set: No space left on device
  +Could not set "long_attr" for <TESTFILE>
  +attr_get: No data available
  +Could not get "long_attr" for <TESTFILE>
  +0000000
  +attr_remove: No data available
  +Could not remove "long_attr" for <TESTFILE>

This is due to the MAX_ATTRVAL_SIZE=65536 setting for NFS, which exceeds
the Btrfs (and XFS) limit of MAX_ATTRVAL_SIZE=64. Change NFS to use this
lower bound value.

Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
---
 common/attr | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/attr b/common/attr
index dae8a1bb..1778e8b2 100644
--- a/common/attr
+++ b/common/attr
@@ -319,13 +319,13 @@ export MAX_ATTRS
 
 # Set max attr value size based on fs type
 case "$FSTYP" in
-xfs|udf|btrfs)
+xfs|udf|btrfs|nfs)
 	MAX_ATTRVAL_SIZE=64
 	;;
 pvfs2)
 	MAX_ATTRVAL_SIZE=8192
 	;;
-9p|ceph|nfs)
+9p|ceph)
 	MAX_ATTRVAL_SIZE=65536
 	;;
 bcachefs)
-- 
2.34.1




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux