There's another call to fchownat() right above it so we really don't need the second one. Cc: Seth Forshee <sforshee@xxxxxxxxxxxxxxxx> Cc: Eryu Guan <guaneryu@xxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: fstests@xxxxxxxxxxxxxxx Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx> --- /* v2 */ - Christian Brauner <brauner@xxxxxxxxxx>: - fix Seth's mail address in commit message --- src/idmapped-mounts/idmapped-mounts.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/idmapped-mounts/idmapped-mounts.c b/src/idmapped-mounts/idmapped-mounts.c index da690779..56b26b0c 100644 --- a/src/idmapped-mounts/idmapped-mounts.c +++ b/src/idmapped-mounts/idmapped-mounts.c @@ -8133,11 +8133,6 @@ static int setgid_create_idmapped_in_userns(void) goto out; } - if (fchownat(t_dir1_fd, "", -1, 1000, AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH)) { - log_stderr("failure: fchownat"); - goto out; - } - pid = fork(); if (pid < 0) { log_stderr("failure: fork"); base-commit: 770f462e17e52c4b2bc026fd707ad01fcce95f32 -- 2.32.0