Re: [PATCH v2 13/16] generic: add mmap CoW test for mixed&source extents

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Dec 06, 2021 at 04:40:40PM -0800, Darrick J. Wong wrote:
> On Thu, Nov 25, 2021 at 03:47:49PM +0800, Shiyang Ruan wrote:
> > Ensuring that copy on write in buffered mode works when the CoW
> > range originally covers multiple extents, mixed with reflinked, unwritten,
> > hole, regular and delalloc blocks.
> > 
> > Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> 
> Looks ok,

...with a _require_command $FILEFRAG_PROG filefrag added.

(Serves me right for reviewing in backwards order.)

--D

> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> --D
> 
> > ---
> >  tests/generic/912     | 67 +++++++++++++++++++++++++++++++++++++++++++
> >  tests/generic/912.out | 12 ++++++++
> >  2 files changed, 79 insertions(+)
> >  create mode 100755 tests/generic/912
> >  create mode 100644 tests/generic/912.out
> > 
> > diff --git a/tests/generic/912 b/tests/generic/912
> > new file mode 100755
> > index 00000000..4f0d94dd
> > --- /dev/null
> > +++ b/tests/generic/912
> > @@ -0,0 +1,67 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# FS QA Test No. 912
> > +#
> > +# Ensuring that copy on write in mmap mode works when the CoW
> > +# range originally covers multiple extents, mixed with reflinked, unwritten,
> > +# hole, regular and delalloc blocks.
> > +#   - Create a file with the following repeating sequence of blocks:
> > +#     1. reflinked
> > +#     2. unwritten
> > +#     3. hole
> > +#     4. regular block
> > +#     5. delalloc
> > +#   - mmap CoW across the halfway mark, starting with the unwritten extent.
> > +#   - Check that the files are now different where we say they're different.
> > +#
> > +. ./common/preamble
> > +_begin_fstest auto quick clone punch
> > +
> > +# Import common functions.
> > +. ./common/filter
> > +. ./common/reflink
> > +
> > +# real QA test starts here
> > +_require_scratch_reflink
> > +_require_xfs_io_command "falloc"
> > +_require_xfs_io_command "fpunch"
> > +_require_cp_reflink
> > +_require_odirect
> > +
> > +echo "Format and mount"
> > +_scratch_mkfs > $seqres.full 2>&1
> > +_scratch_mount >> $seqres.full 2>&1
> > +
> > +testdir=$SCRATCH_MNT/test-$seq
> > +mkdir $testdir
> > +
> > +echo "Create the original files"
> > +blksz=65536
> > +nr=64
> > +filesize=$((blksz * nr))
> > +_sweave_reflink_rainbow $blksz $nr $testdir/file1 $testdir/file3 >> $seqres.full
> > +_scratch_cycle_mount
> > +
> > +echo "Compare files"
> > +md5sum $testdir/file1 | _filter_scratch
> > +md5sum $testdir/file3 | _filter_scratch
> > +md5sum $testdir/file1.chk | _filter_scratch
> > +
> > +echo "mmap CoW across the transition"
> > +cowoff=$((filesize / 4))
> > +cowsz=$((filesize / 2))
> > +_sweave_reflink_rainbow_delalloc $blksz $nr $testdir/file1 >> $seqres.full
> > +# now cow
> > +mmapsz=$((cowoff + cowsz))
> > +_mwrite_byte 0x63 $cowoff $cowsz $mmapsz $testdir/file1 >> $seqres.full
> > +_mwrite_byte 0x63 $cowoff $cowsz $mmapsz $testdir/file1.chk >> $seqres.full
> > +_scratch_cycle_mount
> > +
> > +echo "Compare files"
> > +md5sum $testdir/file1 | _filter_scratch
> > +md5sum $testdir/file3 | _filter_scratch
> > +md5sum $testdir/file1.chk | _filter_scratch
> > +
> > +# success, all done
> > +status=0
> > diff --git a/tests/generic/912.out b/tests/generic/912.out
> > new file mode 100644
> > index 00000000..32f25a1d
> > --- /dev/null
> > +++ b/tests/generic/912.out
> > @@ -0,0 +1,12 @@
> > +QA output created by 912
> > +Format and mount
> > +Create the original files
> > +Compare files
> > +6366fd359371414186688a0ef6988893  SCRATCH_MNT/test-912/file1
> > +bdbcf02ee0aa977795a79d25fcfdccb1  SCRATCH_MNT/test-912/file3
> > +6366fd359371414186688a0ef6988893  SCRATCH_MNT/test-912/file1.chk
> > +mmap CoW across the transition
> > +Compare files
> > +26aa3a0749b867ec58363c8539ee5471  SCRATCH_MNT/test-912/file1
> > +bdbcf02ee0aa977795a79d25fcfdccb1  SCRATCH_MNT/test-912/file3
> > +26aa3a0749b867ec58363c8539ee5471  SCRATCH_MNT/test-912/file1.chk
> > -- 
> > 2.34.0
> > 
> > 
> > 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux