On Thu, Nov 25, 2021 at 03:47:39PM +0800, Shiyang Ruan wrote: > Ensuring that copy on write in mmap mode works when the CoW range originally > covers multiple extents, some unwritten, some not. > (MMAP version of generic/189,188) > > Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> At first I was a little concerned that _mwrite'ing file3.chk could result in us failing to notice a bug in the mmap write paths that hits both reflink and cow writes, but then I realized that this is one of those tests that encode the md5sum in the golden output, so of course we'd notice. I think this looks good, so: Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > tests/generic/902 | 59 +++++++++++++++++++++++++++++++++++++++++++ > tests/generic/902.out | 12 +++++++++ > 2 files changed, 71 insertions(+) > create mode 100755 tests/generic/902 > create mode 100644 tests/generic/902.out > > diff --git a/tests/generic/902 b/tests/generic/902 > new file mode 100755 > index 00000000..457b039a > --- /dev/null > +++ b/tests/generic/902 > @@ -0,0 +1,59 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# > +# FS QA Test No. 902 > +# > +# Ensuring that copy on write in mmap mode works when the CoW > +# range originally covers multiple extents, some unwritten, some not. > +# (MMAP version of generic/189,188) > +# - Create a file and fallocate a second file. > +# - Reflink the odd blocks of the first file into the second file. > +# - mmap CoW across the halfway mark, starting with the unwritten extent. > +# - Check that the files are now different where we say they're different. > +# > +. ./common/preamble > +_begin_fstest auto quick clone > + > +# Import common functions. > +. ./common/filter > +. ./common/reflink > + > +# real QA test starts here > +_require_scratch_reflink > +_require_xfs_io_command "falloc" > + > +echo "Format and mount" > +_scratch_mkfs > $seqres.full 2>&1 > +_scratch_mount >> $seqres.full 2>&1 > + > +testdir=$SCRATCH_MNT/test-$seq > +mkdir $testdir > + > +echo "Create the original files" > +blksz=65536 > +nr=64 > +filesize=$((blksz * nr)) > +_weave_reflink_unwritten $blksz $nr $testdir/file1 $testdir/file3 >> $seqres.full > +_scratch_cycle_mount > + > +echo "Compare files" > +md5sum $testdir/file1 | _filter_scratch > +md5sum $testdir/file3 | _filter_scratch > +md5sum $testdir/file3.chk | _filter_scratch > + > +echo "mmap CoW across the transition" > +cowoff=$((filesize / 4)) > +cowsz=$((filesize / 2)) > +mmapsz=$((cowoff + cowsz)) > +_mwrite_byte 0x63 $cowoff $cowsz $mmapsz $testdir/file3 >> $seqres.full > +_mwrite_byte 0x63 $cowoff $cowsz $mmapsz $testdir/file3.chk >> $seqres.full > +_scratch_cycle_mount > + > +echo "Compare files" > +md5sum $testdir/file1 | _filter_scratch > +md5sum $testdir/file3 | _filter_scratch > +md5sum $testdir/file3.chk | _filter_scratch > + > +# success, all done > +status=0 > +exit > diff --git a/tests/generic/902.out b/tests/generic/902.out > new file mode 100644 > index 00000000..bc951255 > --- /dev/null > +++ b/tests/generic/902.out > @@ -0,0 +1,12 @@ > +QA output created by 902 > +Format and mount > +Create the original files > +Compare files > +bdbcf02ee0aa977795a79d25fcfdccb1 SCRATCH_MNT/test-902/file1 > +fa50dba51826899c372464a153cb2117 SCRATCH_MNT/test-902/file3 > +fa50dba51826899c372464a153cb2117 SCRATCH_MNT/test-902/file3.chk > +mmap CoW across the transition > +Compare files > +bdbcf02ee0aa977795a79d25fcfdccb1 SCRATCH_MNT/test-902/file1 > +09101629908f9bdd5d178e7ce20bb1bb SCRATCH_MNT/test-902/file3 > +09101629908f9bdd5d178e7ce20bb1bb SCRATCH_MNT/test-902/file3.chk > -- > 2.34.0 > > >
