Re: [PATCH] common/module: fix patient module remover when module is not present

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Poke

On Mon, Nov 15, 2021 at 03:28:34PM -0800, Luis Chamberlain wrote:
> When module is not present and the open coded patient module
> remover is called we'll end up in a loop which never ends.
> Fix this.
> 
> I actually found this issue not in fstests, but when applying this
> open coded solution to blktests. In fstest we tend to only call
> module remove when we have a module loaded. blktests is different,
> and so I immediately spotted the issue there.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> ---
>  common/module | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/module b/common/module
> index ead0f881..6efab71d 100644
> --- a/common/module
> +++ b/common/module
> @@ -180,6 +180,8 @@ _patient_rmmod()
>  				continue
>  			fi
>  			let max_tries=$max_tries-1
> +		else
> +			break
>  		fi
>  	done
>  
> -- 
> 2.33.0
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux