Re: [PATCH] fstests: btrfs/011 increase the runtime for replace cancel

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Dec 01, 2021 at 01:19:35PM -0500, Josef Bacik wrote:
> This test exercises the btrfs replace cancel path, but in order to do
> this we have to have enough work to do in order to successfully cancel
> the balance, otherwise the test fails because the operation has
> completed before we're able to cancel.  This test has a very low pass
> rate because we do not generate a large enough file system for replace
> to have enough work, passing around 5% of the time.  Increase the time
> spent to 10x the time we wait for the replace to start its work before
> we cancel, this allows us to consistently pass this test.

I've seen the test to pass most of the time but that it still fails
depending on the load is annoying and requires checking the results. So
even if it's probably a workaround (not sure we can make it 100%
reliable without peeking into the internals) it's making things better.

Acked-by: David Sterba <dsterba@xxxxxxxx>



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux