Re: [PATCH v1 xfstests-dev] common/populate: remove wrong check

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Dec 03, 2021 at 05:54:41PM +0800, Zhu Yifei wrote:
> used btree_dir to check dformat, this was a wrong operation

Huh?  The __populate_check_xfs_dformat you propose removing checks that
the btree-format directory that we just created actually has a data fork
in BTREE format.

The change is incorrect, NAK.

--D

> Signed-off-by: Zhu Yifei <yifeix.zhu@xxxxxxxxx>
> ---
>  common/populate | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/common/populate b/common/populate
> index 867776cd..8ad561b4 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -605,7 +605,6 @@ _scratch_xfs_populate_check() {
>  	__populate_check_xfs_dir "${leafn_dir}" "leafn"
>  	__populate_check_xfs_dir "${node_dir}" "node"
>  	__populate_check_xfs_dir "${btree_dir}" "btree"
> -	__populate_check_xfs_dformat "${btree_dir}" "btree"
>  	__populate_check_xfs_dformat "${bdev}" "dev"
>  	__populate_check_xfs_dformat "${cdev}" "dev"
>  	__populate_check_xfs_dformat "${fifo}" "dev"
> -- 
> 2.20.1
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux