Re: [PATCH] fsstress: improve error message on check_cwd() error

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Nov 03, 2021 at 11:18:22AM -0700, Luis Chamberlain wrote:
> On Wed, Nov 03, 2021 at 09:24:34AM -0700, Darrick J. Wong wrote:
> > > -	if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
> > > +	if (statbuf.st_ino == top_ino)
> > >  		return;
> > > +
> > > +	fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%lu) != top_ino (%lu)\n",
> > > +		statbuf.st_ino, top_ino);
> > 
> > This might want some explicit casting, since this can be defined as
> > anything between unsigned long to uint64_t, at least according to the
> > glibc headers on my system.
> 
> Um, Filipe had suggested something a bit different before. Can you guys
> decide and let me know your final preference ? :)

Any final preference / recommendation?

  Luis



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux