Re: [PATCH 2/3] generic: fix description or typo in head comment

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Oct 29, 2021 at 02:59:42PM +0800, Shiyang Ruan wrote:
> 1. update description according to the current testcase
> 2. "an the end -> at the end"
> 
> Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> ---
>  tests/generic/155 | 3 +--
>  tests/generic/269 | 2 +-
>  tests/generic/270 | 2 +-
>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/generic/155 b/tests/generic/155
> index 2fe7894a..13292fbb 100755
> --- a/tests/generic/155
> +++ b/tests/generic/155
> @@ -13,8 +13,7 @@
>  #   - CoW all the rest of the blocks of the copies
>  #   - Compare fs block usage to (2), (1), and (0)
>  #
> -# The main difference from 834 is that we use zero range, directio, and
> -# mmap to mix things up a bit.
> +# The main difference from No. 154 is that we use zero range to execute CoW.

'The main difference from generic/154 is that...'

>  #
>  . ./common/preamble
>  _begin_fstest auto quick clone zero
> diff --git a/tests/generic/269 b/tests/generic/269
> index d78b7463..60a07b44 100755
> --- a/tests/generic/269
> +++ b/tests/generic/269
> @@ -4,7 +4,7 @@
>  #
>  # FSQA Test No. 269
>  #
> -# Run fsstress and ENSPC hitters in parallel, check fs consistency an the end
> +# Run fsstress and ENSPC hitters in parallel, check fs consistency at the end

ENOSPC, not ENSPC

>  #
>  . ./common/preamble
>  _begin_fstest auto rw prealloc ioctl enospc stress
> diff --git a/tests/generic/270 b/tests/generic/270
> index 1fb5795a..35141e05 100755
> --- a/tests/generic/270
> +++ b/tests/generic/270
> @@ -5,7 +5,7 @@
>  # FSQA Test No. 270
>  #
>  # Run fsstress and ENSPC hitters in parallel, check quota and 
> -# fs consistency an the end
> +# fs consistency at the end

This looks good to me, assuming the lack of a period at the end of the
sentence doesn't bother anyone.  Apparently that's the new style in this
'texting' thing I keep hearing about. ;)

--D

>  #
>  . ./common/preamble
>  _begin_fstest auto quota rw prealloc ioctl enospc stress
> -- 
> 2.33.0
> 
> 
> 



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux