On 28.10.21 г. 12:22, Filipe Manana wrote: > On Thu, Oct 28, 2021 at 10:17 AM Nikolay Borisov <nborisov@xxxxxxxx> wrote: >> >> >> >> On 28.10.21 г. 12:01, Filipe Manana wrote: >>> On Wed, Oct 27, 2021 at 10:25 PM Nikolay Borisov <nborisov@xxxxxxxx> wrote: >> >> <snip> >> >>>> +if [[ ! -e /sys/fs/btrfs/$uuid/exclusive_operation ]]; then >>>> + _notrun "Requires btrfs exclusive operation support" >>>> +fi >>> >>> Why is it required to have the sysfs export file for the exclusive operations? >>> The test doesn't use the file at all, and exclusive operations exist >>> for many years, unlike the sysfs file which is recent. >> >> Because the report mentioned the following error message being printed: >> >> ERROR: unable to start device add, another exclusive operation 'balance' >> in progress >> >> And this comes from check_running_fs_exclop which got added as part of >> the sysfs interface for exclusive ops. > > Ok, so check_running_fs_exclop() is a btrfs-progs function. > > But even before that, and the sysfs file was added, it was not > possible to do a device add while there's stopped balance, no? Most probably yes. Ok I will remove this check then. > >> >>> >> >> <snip> > > >
