Re: [PATCH 2/2] btrfs/091: remove noinode_cache option

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sun, Oct 24, 2021 at 09:34:15PM +0800, Eryu Guan wrote:
> On Mon, Sep 27, 2021 at 03:20:19PM +0800, Ma Xinjian wrote:
> > inode cache feature has been removed
> > 
> > Link: https://www.spinics.net/lists/linux-btrfs/msg107910.html
> 
> >From above link, the inode cache feathre has been removed since v5.11
> kernel, which is relatively a recent kernel,  but old kernels may still
> need this noinode_cache mount option.  So we'd better to keep this
> check.
> 
> We could add check for inode_cache option as well, and only check for
> noinode_cache when inode cache is supported.

I don't think we should keep the option support in the testsuite. There
was deprecation period before actual removal from kernel and long before
that we discouraged everybody from using it. There were known bugs and I
don't think anybody cares for old kernels anyway.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux