On Wed, Oct 20, 2021 at 10:58:56PM +0800, Anand Jain wrote: > > > On 20/10/2021 21:53, Josef Bacik wrote: > > On Wed, Oct 20, 2021 at 03:16:44PM +0800, Anand Jain wrote: > > > If there is a missing seed device in a sprout, the btrfs filesystem usage > > > command fails, which is fixed by the following patches: > > > > > > btrfs: sysfs add devinfo/fsid to retrieve fsid from the device > > > btrfs-progs: read fsid from the sysfs in device_is_seed > > > > > > Test if it works now after these patches in the kernel and in the > > > btrfs-progs respectively. > > > > > > Suggested-by: Josef Bacik <josef@xxxxxxxxxxxxxx> > > > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx> > > > > Shouldn't this use > > > > > > as well? I wish there was a way to detect that btrfs-progs had support for > > reading it but I suppose this is a good enough gate. Maybe add a > > _require_btrfs_sysfs_fsid ? > > The problem is about the nonexistence of the sysfs interface to read fsid. > Adding it will fail to reproduce the problem. > > So if there is no sysfs interface, then btrfs-progs will fail back to the > read-sb method, which shall expose it to fail. > Sigh sorry, I typed this out and then decided I wanted to comment below, and forgot to delete this bit. Yeah sorry I'm thinking about it in terms of the CI testing for us, we'll start failing this test once its merged without the fix merged, but I guess that's kinda what we want. Let's just leave this as it is. Thanks, Josef
