On Mon, Oct 11, 2021 at 02:55:04PM +0100, Luís Henriques wrote: > This test fails when using zram because it's using bs=1k for DIO in fio > jobs. Fix the test by using _min_dio_alignment instead to get the correct > blocksize. > > Signed-off-by: Luís Henriques <lhenriques@xxxxxxx> I'd suggest using the commit summary: generic/095: align DIO read/writes with the supported sector size for the device It might also be worth noting that generic/095 would have been failing not just for zram, but if run on other hardware devices that might have a logical sector size > 1k --- e.g., advanced format HDD's with 4k sectors, DASD's on mainframes with 2k sectors, etc. Note: this change will cause the fio stress workload to do its DIO operations using a block size of 512, which I think is fine for this test. (There might be other tests which are making assumptions about the supported DIO alignment of the scratch device where adjusting the test might be more complicated; fortunately, this doesn't appear to be one of them.) Other than changes to the commit description, feel free to add: Reviewed-by: Theodore Ts'o <tytso@xxxxxxx> Thanks, - Ted
