On Thu, Sep 23, 2021 at 11:41:23AM +0100, Luis Henriques wrote: > Test 'src/t_immutable' assumes the existence of users 'nobody' and > 'daemon' on the system. If any of these users don't exist, the test will > fail with: > > add_acl(/media/scratch/079/immutable.f) did not set errno == EPERM > ... > > because it tries to set ACLs such as: > > u::rwx,g::rwx,o::rwx,u:daemon:rwx,m::rwx > > Use the new _require_user_exists() function to ensure these users exist. > > Signed-off-by: Luis Henriques <lhenriques@xxxxxxx> Looks correct. Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > tests/generic/079 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/generic/079 b/tests/generic/079 > index 829275db8cdf..9e7ccd31c8e2 100755 > --- a/tests/generic/079 > +++ b/tests/generic/079 > @@ -26,6 +26,8 @@ _cleanup() > _supported_fs generic > > _require_chattr ia > +_require_user_exists "nobody" > +_require_user_exists "daemon" > _require_test_program "t_immutable" > _require_scratch >
