Re: [PATCH] common/rc: Check SCRATCH_DEV in _require_dm_target()

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sep 07, 2021 / 18:15, Dave Chinner wrote:
> On Tue, Sep 07, 2021 at 04:41:16PM +0900, Shin'ichiro Kawasaki wrote:
> > When SCRATCH_DEV is not set and the test case does not call
> > _require_scratch*() before _require_dm_target(), _require_block_device()
> 
> That is the bug that needs fixing.

Thanks for the comment. Do you mean the test cases (generic/628 and generic/629)
need fix to call _require_scratch*() before _require_dm_target()? I think that
fix approach will leave the possibility that the newly added test cases in the
future may have the same failure. IMO, the patch posted will be more effective
to prevent the failures.

-- 
Best Regards,
Shin'ichiro Kawasaki



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux