On Thu, Aug 19, 2021 at 05:56:31PM +0300, Nikolay Borisov wrote: > On 19.08.21 г. 18:00, Zorro Lang wrote: > > On Thu, Aug 19, 2021 at 04:13:55PM +0300, Nikolay Borisov wrote: > >> At the end of the test the fsstress work dir is deleted, this suggests > >> the test really requires a scratch device and not a test device. Change > >> it accordingly. > >> > >> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx> > >> --- > > > > Hmm... is there any more specific reasons to explain why have to change this > > TEST_DIR to SCRATCH_MNT? For example, this test hit ENOSPC in TEST_DIR, or > > it takes too much time to remove $TEST_DIR/fsstress in _cleanup, or use > > SCRATCH_DEV can cover more things, and so on. I think more specific reason > > can help to push this patch be merged. After all there's not a rule says > > if a case don't need to keep its work dir, then must use SCRATCH_DEV. Except > > the maintainer is more inclined to accept that :) > > None of the reasons above, I just thought that stuff in $TEST_DEV lives > there so that it can simulate an 'aging' system. In this case this > doesn't seem to be the reason for it as we delete everything. Using SCRATCH_DEV requires that the file system be reformatted, since it doesn't necessarily exist. So that means extra flash writes, and extra time to actually do the file system format. In addition, sometimes SCRATCH_DEV might not be present for some test environments. Hence, unless you need to use SCRATCH_DEV (because the file system needs to be formatted with specific mkfs options, etc.), I think the preference should be to use TEST_DIR. It doesn't *hurt* that we create the work directory, in TEST_DIR and then delete it afterwawrds --- where as using SCRATCH_DEV dosn't actually buy you anything, and might actually slow the test down a tiny bit. Cheers, - Ted
