Re: [PATCH 1/1] misc: tag all tests that examine crash recovery in a loop

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Jul 28, 2021 at 1:10 AM Darrick J. Wong <djwong@xxxxxxxxxx> wrote:
>
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Given all the recent problems that we've been finding with log recovery,
> I think it would be useful to create a 'recoveryloop' group so that
> developers have a convenient way to run every single test that rolls
> around in a fs shutdown loop looking for subtle errors in recovery.
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  tests/btrfs/190   |    2 +-
>  tests/generic/019 |    2 +-
>  tests/generic/388 |    2 +-
>  tests/generic/455 |    2 +-
>  tests/generic/457 |    2 +-
>  tests/generic/475 |    2 +-
>  tests/generic/482 |    2 +-
>  tests/generic/725 |    2 +-
>  tests/xfs/057     |    2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
>
>
> diff --git a/tests/btrfs/190 b/tests/btrfs/190
> index 3aa718e2..974438c1 100755
> --- a/tests/btrfs/190
> +++ b/tests/btrfs/190
> @@ -8,7 +8,7 @@
>  # balance needs to be resumed on mount.
>  #
>  . ./common/preamble
> -_begin_fstest auto quick replay balance qgroup
> +_begin_fstest auto quick replay balance qgroup recoveryloop

For btrfs, there are more tests like this: btrfs/172, btrfs/192 and btrfs/206.

>
>  # Import common functions.
>  . ./common/filter
> diff --git a/tests/generic/019 b/tests/generic/019
> index b8d025d6..db56dac1 100755
> --- a/tests/generic/019
> +++ b/tests/generic/019
> @@ -8,7 +8,7 @@
>  # check filesystem consistency at the end.
>  #
>  . ./common/preamble
> -_begin_fstest aio dangerous enospc rw stress
> +_begin_fstest aio dangerous enospc rw stress recoveryloop
>
>  fio_config=$tmp.fio
>
> diff --git a/tests/generic/388 b/tests/generic/388
> index e41712af..9cd737e8 100755
> --- a/tests/generic/388
> +++ b/tests/generic/388
> @@ -15,7 +15,7 @@
>  # spurious corruption reports and/or mount failures.
>  #
>  . ./common/preamble
> -_begin_fstest shutdown auto log metadata
> +_begin_fstest shutdown auto log metadata recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/455 b/tests/generic/455
> index 62788798..13d326e7 100755
> --- a/tests/generic/455
> +++ b/tests/generic/455
> @@ -7,7 +7,7 @@
>  # Run fsx with log writes to verify power fail safeness.
>  #
>  . ./common/preamble
> -_begin_fstest auto log replay
> +_begin_fstest auto log replay recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/457 b/tests/generic/457
> index d9e38268..f4fdd81d 100755
> --- a/tests/generic/457
> +++ b/tests/generic/457
> @@ -7,7 +7,7 @@
>  # Run fsx with log writes on cloned files to verify power fail safeness.
>  #
>  . ./common/preamble
> -_begin_fstest auto log replay clone
> +_begin_fstest auto log replay clone recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/475 b/tests/generic/475
> index 62894491..c426402e 100755
> --- a/tests/generic/475
> +++ b/tests/generic/475
> @@ -12,7 +12,7 @@
>  # testing efforts.
>  #
>  . ./common/preamble
> -_begin_fstest shutdown auto log metadata eio
> +_begin_fstest shutdown auto log metadata eio recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/482 b/tests/generic/482
> index f26e6fc4..0fadf795 100755
> --- a/tests/generic/482
> +++ b/tests/generic/482
> @@ -9,7 +9,7 @@
>  # Will do log replay and check the filesystem.
>  #
>  . ./common/preamble
> -_begin_fstest auto metadata replay thin
> +_begin_fstest auto metadata replay thin recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
> diff --git a/tests/generic/725 b/tests/generic/725
> index f43bcb37..8bd724e3 100755
> --- a/tests/generic/725
> +++ b/tests/generic/725
> @@ -12,7 +12,7 @@
>  # in writeback on the host that cause VM guests to fail to recover.
>  #
>  . ./common/preamble
> -_begin_fstest shutdown auto log metadata eio
> +_begin_fstest shutdown auto log metadata eio recoveryloop
>
>  _cleanup()
>  {
> diff --git a/tests/xfs/057 b/tests/xfs/057
> index d4cfa8dc..9fb3f406 100755
> --- a/tests/xfs/057
> +++ b/tests/xfs/057
> @@ -21,7 +21,7 @@
>  # Note that this test requires a DEBUG mode kernel.
>  #
>  . ./common/preamble
> -_begin_fstest auto log
> +_begin_fstest auto log recoveryloop
>
>  # Override the default cleanup function.
>  _cleanup()
>


-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux