Re: [PATCH] btrfs/242: test case to fstrim on a degraded filesystem

[Anand Jain <anand.jain@xxxxxxxxxx>]

On 05/07/2021 16:50, Filipe Manana wrote:
> On Sun, Jul 4, 2021 at 12:24 PM Anand Jain <anand.jain@xxxxxxxxxx> wrote:
> > Create a degraded btrfs filesystem and run fstrim on it.
> >
> > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
> > ---
> >   tests/btrfs/242     | 49 +++++++++++++++++++++++++++++++++++++++++++++
> >   tests/btrfs/242.out |  2 ++
> >   2 files changed, 51 insertions(+)
> >   create mode 100755 tests/btrfs/242
> >   create mode 100644 tests/btrfs/242.out
> >
> > diff --git a/tests/btrfs/242 b/tests/btrfs/242
> > new file mode 100755
> > index 000000000000..e946ee6ac7c2
> > --- /dev/null
> > +++ b/tests/btrfs/242
> > @@ -0,0 +1,49 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (C) 2021 Oracle. All Rights Reserved.
> > +#
> > +# FS QA Test 242
> > +#
> > +# Test that fstrim can run on the degraded filesystem
> > +#   Kernel requires fix for the null pointer deref in btrfs_trim_fs()
> > +#     [patch] btrfs: check for missing device in btrfs_trim_fs
> > +
> > +
> > +. ./common/preamble
> > +_begin_fstest auto quick replace trim
>
> Also, this does not belong to the 'replace' group (again copied from
> btrfs/223 it seems).

 Oh no. Will fix it. Thanks.

- Anand

> Thanks.
>
> > +
> > +# Import common functions.
> > +. ./common/filter
> > +
> > +# real QA test starts here
> > +_supported_fs btrfs
> > +_require_btrfs_forget_or_module_loadable
> > +_require_scratch_dev_pool 2
> > +#_require_command "$WIPEFS_PROG" wipefs
> > +
> > +_scratch_dev_pool_get 2
> > +dev1=$(echo $SCRATCH_DEV_POOL | $AWK_PROG '{ print $1 }')
> > +
> > +_scratch_pool_mkfs "-m raid1 -d raid1"
> > +_scratch_mount
> > +_require_batched_discard $SCRATCH_MNT
> > +
> > +# Add a test file with some data.
> > +$XFS_IO_PROG -f -c "pwrite -S 0xab 0 10M" $SCRATCH_MNT/foo > /dev/null
> > +
> > +# Unmount the filesystem.
> > +_scratch_unmount
> > +
> > +# Mount the filesystem in degraded mode
> > +_btrfs_forget_or_module_reload
> > +_mount -o degraded $dev1 $SCRATCH_MNT
> > +
> > +# Run fstrim
> > +$FSTRIM_PROG $SCRATCH_MNT
> > +
> > +_scratch_dev_pool_put
> > +
> > +echo Silence is golden
> > +
> > +status=0
> > +exit
> > diff --git a/tests/btrfs/242.out b/tests/btrfs/242.out
> > new file mode 100644
> > index 000000000000..a46d77702f23
> > --- /dev/null
> > +++ b/tests/btrfs/242.out
> > @@ -0,0 +1,2 @@
> > +QA output created by 242
> > +Silence is golden
> > --
> > 2.27.0