Hi,
On 6/28/21 9:05 PM, Darrick J. Wong wrote:
On Mon, Jun 28, 2021 at 02:22:58PM +0530, Anju T Sudhakar wrote:
xfs_db commands like `attr_remove, attr_set, btheight, and logformat`,
are documented only in xfsprogs version v5.5 and later. So skip checking
for these commands in xfs_db manpage,if the test is running with
xfsprogs version less than v5.5.
Signed-off-by: Anju T Sudhakar <anju@xxxxxxxxxxxxxxxxxx>
---
Query: The reason to add this check is, while running xfstest with an
older version of xfsprogs, this test case flags as failure, though
xfs_db is not expected to have those commands. Otherwise upon failure we
should ask the user to use the latest version of xfsprogs.
OR is there any better solution for this?
If you're shipping xfsprogs 5.5 in a product, why not update the manpage
to document the functionality that's in your product? If you aren't
shipping 5.5, then why run such an old version?
--D
OK. Then I think we can drop patch 2/3 and 3/3 in this series, as both
checks for the
xfsprogs version to run the test.
Thanks,
Anju
