on 2021/6/22 9:58, xuyang2018.jy@xxxxxxxxxxx wrote: > on 2021/6/22 0:48, Theodore Ts'o wrote: >> ext4/048 will fail when running on older kernels that don't support >> the filename wipe feature. The journal checkpoint ioctl is a related >> feature, and landed just a little bit after filename wipe feature, so >> use support for the journal checkpoint ioctl as a proxy for support >> for the filename wipe feature. >> >> Without this change, this test will fail when tesing 5.10, 5.4, and >> other LTS kernels. > Thanks. With this patch, it fix failure on centos7.9 and centos8.4. But > I can't find kernel commit for filename wipe feature and journal > checkpoint ioctl. Can you provide them in commit message? I guess filename wipe feature commit is [1]https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=6c0912739699d8e4b6a87086401bf3ad3c59502d and journal checkpoint iocl commit is [2]https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=339183dfb87ce94f8e14a0db48cae093516e194c Since the commit[1] is a feature and this case is desinged to test this feature, so skipping this test looks ok on non-supported kernel. Tested-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx> > > Best Regards > Yang Xu >> >> Signed-off-by: Theodore Ts'o<tytso@xxxxxxx> >> Cc: Leah Rumancik<leah.rumancik@xxxxxxxxx> >> --- >> tests/ext4/048 | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/tests/ext4/048 b/tests/ext4/048 >> index 51189618..35e6aa7f 100755 >> --- a/tests/ext4/048 >> +++ b/tests/ext4/048 >> @@ -93,6 +93,14 @@ _scratch_mkfs_sized $((128 * 1024 * 1024))>> $seqres.full 2>&1 >> # create scratch dir for testing >> # create some files with no name a substr of another name so we can grep later >> _scratch_mount>> $seqres.full 2>&1 >> + >> +# Use the presence of the journal checkpoint ioctl as a proxy of filename >> +# wipe being supported >> +if test -x $here/src/checkpoint_journal&& \ >> + ! $here/src/checkpoint_journal $SCRATCH_MNT --dry-run ; then >> + _notrun "filename wipe not supported" >> +fi >> + >> blocksize="$(_get_block_size $SCRATCH_MNT)" >> mkdir $testdir >> file_num=1 > >
