Re: [PATCH 07/13] fstests: automatically generate group files

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Jun 18, 2021 at 06:32:18PM +0300, Amir Goldstein wrote:
> On Fri, Jun 18, 2021 at 4:47 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> >
> > On Thu, Jun 17, 2021 at 10:15:00AM -0700, Darrick J. Wong wrote:
> > > I suppose I could make the '-g' switch call 'make group.list', though
> > > that's just going to increase the amount of noise for anyone like me who
> > > runs fstests with a mostly readonly rootfs.
> >
> > Just stick to the original version and see if anyone screams loud
> 
> What is the original version?

Assuming the developer is smart enough to run 'make all install' before
running fstests.

--D

> > enough.  Of course the best long-term plan would be to not even generate
> > group files by just calculate the list in-memory.
> 
> Why in-memory?
> check already creates $tmp.list with the list of test files right?
> Any reason not to the group.list files under /tmp while preparing
> the test list instead of creating them in the src directory?
> 
> Thanks,
> Amir.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux