Re: [PATCH 12/13] fstests: remove test group management code

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Jun 16, 2021 at 01:58:21PM -0700, Eric Biggers wrote:
> On Mon, Jun 14, 2021 at 02:00:05PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > Remove all the code that manages group files, since we now generate
> > them at build time.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > Reviewed-by: Chandan Babu R <chandanrlinux@xxxxxxxxx>
> > Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> > ---
> >  tools/mvtest     |   12 ------
> >  tools/sort-group |  112 ------------------------------------------------------
> >  2 files changed, 124 deletions(-)
> >  delete mode 100755 tools/sort-group
> > 
> > 
> > diff --git a/tools/mvtest b/tools/mvtest
> > index 572ae14e..fa967832 100755
> > --- a/tools/mvtest
> > +++ b/tools/mvtest
> > @@ -32,24 +32,12 @@ did="$(basename "${dest}")"
> >  sgroup="$(basename "$(dirname "tests/${src}")")"
> >  dgroup="$(basename "$(dirname "tests/${dest}")")"
> >  
> > -sgroupfile="tests/${sgroup}/group"
> > -dgroupfile="tests/${dgroup}/group"
> 
> The 'sgroup' and 'dgroup' variables are no longer used and should be removed.

Good catch; deleted.

--D

> 
> - Eric



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux