在 2021/6/6 22:07, Eryu Guan 写道:
On Tue, Jun 01, 2021 at 04:20:05AM -0400, Sun Ke wrote:
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However,
f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again.
But at least we need to configure mininum size of f2fs image to 52MB now.
Suggested-by: Chao Yu <yuchao0@xxxxxxxxxx>
Signed-off-by: Sun Ke <sunke32@xxxxxxxxxx>
---
tests/generic/042 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/generic/042 b/tests/generic/042
index ee0e4b400c71..bf3b4180b1a2 100755
--- a/tests/generic/042
+++ b/tests/generic/042
@@ -43,9 +43,12 @@ _crashtest()
file=$mnt/file
size=25M
- # 25M is too small for f2fs.
+ # f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However,
+ # f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change
+ # again. But at least we need to configure mininum size of f2fs image
+ # to 52MB now.
It'd be better to specify a slightly bigger fs size for f2fs then. I
don't think this test depends on the fs size, just that smaller size
makes test run faster.
Maybe 64M or 128M, any suggestions from f2fs folks?
Thanks,
Eryu
I tested both of them, they both take 5s. So, the bigger is the better,
I choose 128M.
[root@localhost xfstests-dev]# git diff
diff --git a/tests/generic/042 b/tests/generic/042
index bf3b4180..e5d272ca 100755
--- a/tests/generic/042
+++ b/tests/generic/042
@@ -48,7 +48,7 @@ _crashtest()
# again. But at least we need to configure mininum size of f2fs
image
# to 52MB now.
if [ $FSTYP == "f2fs" ]; then
- size=52M
+ size=64M
fi
# Create an fs on a small, initialized image. The pattern is
written to
[root@localhost xfstests-dev]# ./check tests/generic/042
FSTYP -- f2fs
PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP
Tue Jun 8 11:09:37 CST 2021
MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/042 5s ... 5s
Ran: generic/042
Passed all 1 tests
[root@localhost xfstests-dev]# git diff
diff --git a/tests/generic/042 b/tests/generic/042
index bf3b4180..c103959b 100755
--- a/tests/generic/042
+++ b/tests/generic/042
@@ -48,7 +48,7 @@ _crashtest()
# again. But at least we need to configure mininum size of f2fs
image
# to 52MB now.
if [ $FSTYP == "f2fs" ]; then
- size=52M
+ size=128M
fi
# Create an fs on a small, initialized image. The pattern is
written to
[root@localhost xfstests-dev]# ./check tests/generic/042
FSTYP -- f2fs
PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP
Tue Jun 8 11:09:37 CST 2021
MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/042 5s ... 5s
Ran: generic/042
Passed all 1 tests
Thanks,
Sun Ke
if [ $FSTYP == "f2fs" ]; then
- size=38M
+ size=52M
fi
# Create an fs on a small, initialized image. The pattern is written to
--
2.25.4
.
