On Thu, Jun 03, 2021 at 07:56:49PM +0300, Amir Goldstein wrote: > On Thu, Jun 3, 2021 at 6:34 PM Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > > > On Thu, Jun 03, 2021 at 09:32:16AM +0300, Amir Goldstein wrote: > > > On Wed, May 26, 2021 at 5:50 AM Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > > > > > > > Hi all, > > > > > > > > Test group files (e.g. tests/generic/group) are a pain to keep up. > > > > Every week I rebase on Eryu's latest upstream, and every week I have to > > > > slog through dozens of trivial merge conflicts because of the > > > > groupfiles. Moving tests is annoying because we have to maintain all > > > > this code to move the group associations from one /group file to > > > > another. > > > > > > > > It doesn't need to be this way -- we could move each test's group > > > > information into the test itself, and automatically generate the group > > > > files as part of the make process. This series does exactly that. > > > > > > > > > > This looks very nice :) > > > > > > I do have one concern. > > > If the auto-generated group files keep the same path as the existing > > > source controlled group files, checkout of pre/post this change is > > > going to be challenging for developers running make in the source > > > directory. > > > > <nod> A temporary pain until everyone rebases, but you're right, that's > > going to annoy people unnecessarily. > > > > Admittedly I left it as tests/*/group to avoid making any other changes. > > All three lines' worth in check. :P > > > > > Also .gitignore entries are needed for the auto-generated group files. > > > > Heh, oops. Will fix. > > > > > I wonder if it wouldn't be easier for everyone if the auto-generated > > > groups had a different name. > > > > Probably. We could blast fstests 25 years into the future and change > > the name to "hashtag" :P > > > > How about "group.map" ? > > > > <shrug> that's the hardest part ;-) > > I'm fine with group.map group.list group.autogen or whatnot. > > I am used to typing the prefix of the group file path in shell commands, > but auto-complete should take care of any suffix. I went with group.list. --D > Thanks, > Amir.
