On Thu, Apr 29, 2021 at 11:05 AM Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx> wrote: > > On 29/04/2021 11:56, Filipe Manana wrote: > > On Thu, Apr 29, 2021 at 10:44 AM Johannes Thumshirn > > <Johannes.Thumshirn@xxxxxxx> wrote: > >> > >> On 28/04/2021 11:24, Filipe Manana wrote: > >>> The use of _fail is usually discouraged. A simple echo would suffice here. > >> > >> > >> Need to do echo + exit here, otherwise there will be errors in the shell script. > > > > Errors? I don't understand, what kind of errors? > > > For instance if the block group isn't removed, the dump-tree call will return two > block groups and then this calculation will fail: > new_data_zone=$(get_data_bg) > new_data_zone=$((new_data_zone >> 9)) Ok, I now see it, I was only noticing the very last _fail, which is not problematic. Sounds good then. Thanks. -- Filipe David Manana, “Whether you think you can, or you think you can't — you're right.”
