[PATCH 5/5] xfs/49[12]: skip pre-lazysbcount filesystems

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



From: Darrick J. Wong <djwong@xxxxxxxxxx>

Prior to lazysbcount, the xfs mount code blindly trusted the value of
the fdblocks counter in the primary super, which means that the kernel
doesn't detect the fuzzed fdblocks value at all.  V4 is deprecated and
pre-lazysbcount V4 hasn't been the default for ~14 years, so we'll just
skip these two tests on those old filesystems.

Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
---
 tests/xfs/491 |    5 +++++
 tests/xfs/492 |    5 +++++
 2 files changed, 10 insertions(+)


diff --git a/tests/xfs/491 b/tests/xfs/491
index 6420202b..9fd0ab56 100755
--- a/tests/xfs/491
+++ b/tests/xfs/491
@@ -36,6 +36,11 @@ _require_scratch
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
+
+# pre-lazysbcount filesystems blindly trust the primary sb fdblocks
+_check_scratch_xfs_features LAZYSBCOUNT &>/dev/null || \
+	_notrun "filesystem requires lazysbcount"
+
 _scratch_mount >> $seqres.full 2>&1
 echo "test file" > $SCRATCH_MNT/testfile
 
diff --git a/tests/xfs/492 b/tests/xfs/492
index 522def47..c4b087b5 100755
--- a/tests/xfs/492
+++ b/tests/xfs/492
@@ -36,6 +36,11 @@ _require_scratch
 
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
+
+# pre-lazysbcount filesystems blindly trust the primary sb fdblocks
+_check_scratch_xfs_features LAZYSBCOUNT &>/dev/null || \
+	_notrun "filesystem requires lazysbcount"
+
 _scratch_mount >> $seqres.full 2>&1
 echo "test file" > $SCRATCH_MNT/testfile
 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux