on 2021/4/26 22:32, Christian Brauner wrote: > On Mon, Apr 26, 2021 at 02:23:06PM +0800, Yang Xu wrote: >> We don't add fallback for renameat2, so it build failed on old kernel. >> Also, renameat2() man-pages said as below: >> "renameat2() has an additional flags argument. A renameat2() call with >> a zero flags argument is equivalent to renameat()." >> >> In this src file, it uses zero flag for all renameat2 call. So we can use >> renameat directly. >> >> Signed-off-by: Yang Xu<xuyang2018.jy@xxxxxxxxxxx> >> --- > > Looks ok. You made sure that this passes after this change, right? Yes. It passes after this change. > Reviewed-by: Christian Brauner<christian.brauner@xxxxxxxxxx>