Re: [PATCH] xfs/145: Remove useless -f option for xfs_quota command

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Apr 22, 2021 at 01:05:43PM +0800, Yang Xu wrote:
> Since it is a xfs specifal case, we don't need to use foreign filesystem mode.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@xxxxxxxxxxx>
> Signed-off-by: Jinhui Huang <huangjh.jy@xxxxxxxxxxx>
> ---

Seems reasonable. Any particular reason for this change, or just an
observation?

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  tests/xfs/145 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/xfs/145 b/tests/xfs/145
> index 3b3c375d..3ccbb923 100755
> --- a/tests/xfs/145
> +++ b/tests/xfs/145
> @@ -51,7 +51,7 @@ $FILEFRAG_PROG -v $SCRATCH_MNT/testy 2>&1 | grep -q delalloc || \
>  rm -f $SCRATCH_MNT/testy
>  
>  echo "Run test program"
> -$XFS_QUOTA_PROG -f -x -c 'report -ap' $SCRATCH_MNT >> $seqres.full
> +$XFS_QUOTA_PROG -x -c 'report -ap' $SCRATCH_MNT >> $seqres.full
>  $here/src/chprojid_fail $SCRATCH_MNT/blah
>  
>  # The regression we're testing for is an accounting bug involving delalloc
> @@ -64,7 +64,7 @@ $FILEFRAG_PROG -v $SCRATCH_MNT/blah 2>&1 | grep -q delalloc || \
>  	echo "file didn't get delalloc extents, test invalid?"
>  
>  # Make a note of current quota status for diagnostic purposes
> -$XFS_QUOTA_PROG -f -x -c 'report -ap' $SCRATCH_MNT >> $seqres.full
> +$XFS_QUOTA_PROG -x -c 'report -ap' $SCRATCH_MNT >> $seqres.full
>  
>  # success, all done
>  status=0
> -- 
> 2.23.0
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux