On Mon, Apr 19, 2021 at 12:04:42PM +1000, Dave Chinner wrote: > On Sun, Apr 18, 2021 at 10:44:08AM -0400, Theodore Ts'o wrote: > > On Sun, Apr 18, 2021 at 08:25:48PM +0800, Eryu Guan wrote: > > > > diff --git a/tests/generic/223 b/tests/generic/223 > > > > index 1f85efe5..a5ace82f 100755 > > > > --- a/tests/generic/223 > > > > +++ b/tests/generic/223 > > > > @@ -43,6 +43,9 @@ for SUNIT_K in 8 16 32 64 128; do > > > > _scratch_mkfs_geom $SUNIT_BYTES 4 $BLOCKSIZE >> $seqres.full 2>&1 > > > > _scratch_mount > > > > > > > > + # Make sure everything is on the data device > > > > + $XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT > > > > > > What does this do for non-xfs filesystems? Do we need a FSTYP check and > > > do chattr only on XFS? Yes, I think so. Will fix. > > This clears the FS_NOTAIL_FL flag, which prevents tail merging, on the > > No, this is not the 'chattr' CLI program. This is the xfs_io > 'chattr' command, and they have different attribute namespaces. See > xfs_io for the definitions, but in this case: > > t inherit realtime flag (XFS_XFLAG_RTINHERIT) > > And so clearing that flag ensures that all newly created files > are on the data device, as per the comment... > > > I also have no idea why this helps for xfs --- I would think it's a > > no-op, > > Because it's not what you think it is. :) (Indeed.) --D > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx
