On 4/1/21 4:47 AM, Pavel Reichl wrote: >> We only use whitelist if it's impossible to do such check. >> >> Thanks, >> Eryu >> > Hi, > > it does fail. It was actually my original intention to write the _require*() so it would check if the command succeeds as you are suggesting. > > However, Eric and Dave were worried that adding more _require*() through the tests would lead to further slowing test execution. This worry actually makes sense to me. > > Is there a significant benefit of testing the support vs. maintaining check based on FSTYP variable? I guess doing the check saves us from the need to update the code when new file-system is added, however actually doing the check increases time of test execution (but I haven't done any measurements yet - it's just my guess). > > I really don't mind doing it either way and I'm happy to change the code - I'm just trying to explain :-) that's my fault, sorry. Dave had expressed some concern about exfat changes slowing down testing for every other fs, and we talked about a whitelist. But now that I think about it, I'm not sure this functiona test takes any real extra time. Pavel, maybe you can just evaluate whether there really is any significant time difference, and if there is not, go back to the functional test. Sorry for the hassle. -Eric
