Re: [PATCH v10 0/6] fstests: add idmapped mounts tests

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 24, 2021 at 04:01:18PM +0200, Amir Goldstein wrote:
> > > Meanwhile, found a bug in Makefile:
> > >
> > > --- a/src/idmapped-mounts/Makefile
> > > +++ b/src/idmapped-mounts/Makefile
> > > @@ -25,11 +25,11 @@ depend: .dep
> > >
> > >  include $(BUILDRULES)
> > >
> > > -idmapped-mounts:
> > > +idmapped-mounts: $(CFILES_IDMAPPED_MOUNTS)
> > >         @echo "    [CC]    $@"
> > >         $(Q)$(LTLINK) $(CFILES_IDMAPPED_MOUNTS) -o $@ $(CFLAGS)
> > > $(LDFLAGS) $(LDLIBS)
> > >
> > > -mount-idmapped:
> > > +mount-idmapped: $(CFILES_MOUNT_IDMAPPED)
> > >         @echo "    [CC]    $@"
> > >         $(Q)$(LTLINK) $(CFILES_MOUNT_IDMAPPED) -o $@ $(CFLAGS)
> > > $(LDFLAGS) $(LDLIBS)
> >
> > Stupid question maybe but what is the reason for this change?
> > It builds fine without those lines.
> >
> > Building idmapped-mounts
> > [CC]    idmapped-mounts
> > [CC]    mount-idmapped
> >
> 
> My mistake. You are right. It should be fine as is.
> I may have messed up something else while building.
> 
> You may take the fix or leave it - as you wish.

Eh, it kinda makes it more obvious to have the lines there and they
don't hurt so I've added your change.

Christian



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux