Re: [PATCH v10 1/6] generic/631: add test for detached mount propagation

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Mar 22, 2021 at 3:46 PM Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> From: Christian Brauner <christian.brauner@xxxxxxxxxx>
>
> Regression test to verify that creating a series of detached mounts,
> attaching them to the filesystem, and unmounting them does not trigger an
> integer overflow in ns->mounts causing the kernel to block any new mounts in
> count_mounts() and returning ENOSPC because it falsely assumes that the
> maximum number of mounts in the mount namespace has been reached, i.e. it
> thinks it can't fit the new mounts into the mount namespace anymore.
>
> The test is written in a way that it will leave the host's mount
> namespace intact so we are sure to never make the host's mount namespace
> unuseable!
>
> Link: https://git.kernel.org/torvalds/c/ee2e3f50629f17b0752b55b2566c15ce8dafb557
> Cc: Eryu Guan <guan@xxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
> ---
> /* v1 - v8 */
> patch not present
>
> /* v9 */
> - Christian Brauner <christian.brauner@xxxxxxxxxx>:
>   - Rebased on current master.
>
> /* v10 */
> - Eryu Guan <guan@xxxxxxx>:
>   - Add missing checks whether test is supported.
>   - Move status=$? assignment up.
> ---

Technical nit: why did you add this extra --- line?
It causes all the patch changelog to appear in the commit message.
I don't think that was your intention? and I don't think it adds valuable
into to git log.

Thanks,
Amir.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux