On Sun, Mar 14, 2021 at 10:34:59PM +0800, Zorro Lang wrote: > On Sun, Mar 14, 2021 at 07:42:06PM +0800, Eryu Guan wrote: > > On Thu, Mar 11, 2021 at 08:12:13PM +0800, Zorro Lang wrote: > > > When we test different filesystems with different sections in config > > > file, always hit below failure: > > > ... > > > our local _test_mkfs routine ... > > > mkfs.xfs: /dev/vdb1 appears to contain an existing filesystem (xfs) > > > mkfs.xfs: Use the -f option to force overwrite. > > > check: failed to mkfs $TEST_DEV using specified options > > > ... > > > > > > To fix this problem, change the _test_mkfs to deal with xfs creation > > > properly. Due to xfstests uses _test_mkfs rarely, currently only in > > > check program, so I don't intend to write a whole new series of > > > _test_mkfs_xfs_* functions likes what _scratch_mkfs_xfs_* does. > > > > > > Reported-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > > > I also have defined different test sections in config file to test > > different filesysms, but I didn't hit this failure. And it turns out > > that I have "-f" in MKFS_OPTIONS, e.g. > > > > [xfs_prjquota_crc] > > FSTYP=xfs > > MKFS_OPTIONS="-f -b size=4k -m crc=1" > > MOUNT_OPTIONS="-o prjquota" > > > > [xfs_allquota_reflink] > > FSTYP=xfs > > MKFS_OPTIONS="-f -b size=4k -m crc=1,reflink=1,rmapbt=1" > > MOUNT_OPTIONS="-o usrquota,grpquota,prjquota" > > Yes, set "-f" in MKFS_OPTIONS will help. > > BTW, according to below logic: > > if $RECREATE_TEST_DEV || [ "$OLD_FSTYP" != "$FSTYP" ]; then > ... > if ! _test_mkfs >$tmp.err 2>&1 > > Your TEST_DEV might not be re-created, except you set RECREATE_TEST_DEV=ture. Yes, I also have RECREATE_TEST_DEV=true set in my local.config > I hit this failure due to I set: > [ext4] > FSTYP=ext4 > ... > > [xfs] > FSTYP=xfs > ... > > And ext4 use "-F" by default, but xfs doesn't. > > ext2|ext3|ext4) > $MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* $TEST_DEV > > This patch isn't necessary, due to there's workaround. I'm fine if you'd like > to Nack it. Agreed, not taken :) Thanks, Eryu
