On Mon, Mar 01, 2021 at 06:32:51PM +0100, Christoph Hellwig wrote: > > +# Modify as appropriate. > > +_supported_fs ext4 xfs > > I think this should be > > _supported_fs generic > > now that we do the probing for the actual support, and any file system > not supporting it will just do a _notrun from _require_idmapped_mounts. > > Also the comment above this line should be dropped. The rest of this series still hasn't shown up in my inbox... ...but I did wonder, have you all tested file creation with idmapped mounts and quotas enabled? I noticed after the fact (sorry...) that the dqalloc call just prior to creating the inode still uses current_fs[ug]id() and not the fs[ug]id_into_mnt() call that the conversion series uses. (The fact that xfs access the ids once for quota and again when actually creating the inode is screaming for a cleanup, by the way...) --D
