On Wed, Oct 28, 2020 at 09:03:39PM -0700, Palmer Dabbelt wrote:
> When I compile this normally I end up with the definition of
> MAX_HANDLE_SZ, but when I compile it in a minimal buildroot-based
> environment I don't. I'm not sure where this is supposed to come from,
> but as of 3f4760c2 ("open_by_handle: add option -z to query file handle
> size") it appears to be unnecessary.
Hmmm - it should be trivial to find where it comes from with grep:
$ grep -R MAX_HANDLE_SZ /usr/include
/usr/include/x86_64-linux-gnu/bits/fcntl-linux.h:# define MAX_HANDLE_SZ 128
$
IOWs, MAX_HANDLE_SZ is defined via:
#include <fcntl.h>
which src/open_by_handle.c already includes.
IOWs, this looks like a problem with your build root environment not
defining MAX_HANDLE_SZ correctly, not a problem with fstests.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
