On Sun, Sep 27, 2020 at 05:57:07PM +0800, Eryu Guan wrote:
> On Thu, Sep 24, 2020 at 02:43:48PM +0000, Sidong Yang wrote:
> > This new test will test btrfs's qgroup assign functionality. The
> > test has 3 cases.
> >
> > - assign, no shared extents
> > - assign, shared extents
> > - snapshot -i, shared extents
> >
> > Each cases create subvolumes and assign qgroup in their own way
> > and check with the command "btrfs check".
> >
> > Cc: Qu Wenruo <wqu@xxxxxxxx>
> > Cc: Eryu Guan <guan@xxxxxxx>
> >
> > Signed-off-by: Sidong Yang <realwakka@xxxxxxxxx>
> > ---
> > v2:
> > - Create new test and use the cases
> > v3:
> > - Fix some minor mistakes
> > - Make that write some data before assign or snapshot in test
> > - Put mkfs & mount pair in test function
> > v4:
> > - Add rescan command for assign no shared
> > - Use _check_scratch_fs for checking
> > ---
> > tests/btrfs/221 | 116 ++++++++++++++++++++++++++++++++++++++++++++
> > tests/btrfs/221.out | 2 +
> > tests/btrfs/group | 1 +
> > 3 files changed, 119 insertions(+)
> > create mode 100755 tests/btrfs/221
> > create mode 100644 tests/btrfs/221.out
> >
> > diff --git a/tests/btrfs/221 b/tests/btrfs/221
> > new file mode 100755
> > index 00000000..6b7c9674
> > --- /dev/null
> > +++ b/tests/btrfs/221
> > @@ -0,0 +1,116 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2020 Sidong Yang. All Rights Reserved.
> > +#
> > +# FS QA Test 221
> > +#
> > +# Test the assign functionality of qgroups
> > +#
> > +seq=`basename $0`
> > +seqres=$RESULT_DIR/$seq
> > +echo "QA output created by $seq"
> > +
> > +here=`pwd`
> > +tmp=/tmp/$$
> > +status=1 # failure is the default!
> > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > +
> > +_cleanup()
> > +{
> > + cd /
> > + rm -f $tmp.*
> > +}
> > +
> > +# get standard environment, filters and checks
> > +. ./common/rc
> > +. ./common/filter
> > +. ./common/reflink
> > +
> > +# remove previous $seqres.full before test
> > +rm -f $seqres.full
> > +
> > +# real QA test starts here
> > +
> > +# Modify as appropriate.
> > +_supported_fs btrfs
> > +_supported_os Linux
> > +
> > +_require_scratch
> > +_require_btrfs_qgroup_report
> > +_require_cp_reflink
> > +
> > +# Test assign qgroup for submodule with shared extents by reflink
> > +assign_shared_test()
> > +{
> > + _scratch_mkfs > /dev/null 2>&1
> > + _scratch_mount
> > +
> > + echo "=== qgroup assign shared test ===" >> $seqres.full
> > + $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full
> > +
> > + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/a >> $seqres.full
> > + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/b >> $seqres.full
> > +
> > + _ddt of="$SCRATCH_MNT"/a/file1 bs=1M count=1 >> $seqres.full 2>&1
> > + cp --reflink=always "$SCRATCH_MNT"/a/file1 "$SCRATCH_MNT"/b/file1
>
> There's a helper to do this, _cp_reflink.
>
> > +
> > + $BTRFS_UTIL_PROG qgroup create 1/100 $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG qgroup assign $SCRATCH_MNT/a 1/100 $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG qgroup assign $SCRATCH_MNT/b 1/100 $SCRATCH_MNT
> > +
> > + _scratch_unmount
> > + _check_scratch_fs
> > +}
> > +
> > +# Test assign qgroup for submodule without shared extents
> > +assign_no_shared_test()
> > +{
> > + _scratch_mkfs > /dev/null 2>&1
> > + _scratch_mount
> > +
> > + echo "=== qgroup assign no shared test ===" >> $seqres.full
> > + $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full
>
> Trailing whitespace in above line.
>
> > +
> > + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/a >> $seqres.full
> > + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/b >> $seqres.full
> > +
>
> Trailing whitespace in above line.
>
> > + $BTRFS_UTIL_PROG qgroup create 1/100 $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG qgroup assign $SCRATCH_MNT/a 1/100 $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG qgroup assign $SCRATCH_MNT/b 1/100 $SCRATCH_MNT
> > +
>
> Trailing whitespace in above line.
>
> > + _scratch_unmount
> > + _check_scratch_fs
> > +}
> > +
> > +# Test snapshot with assigning qgroup for submodule
> > +snapshot_test()
> > +{
> > + _scratch_mkfs > /dev/null 2>&1
> > + _scratch_mount
> > +
> > + echo "=== qgroup snapshot test ===" >> $seqres.full
> > + $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT
> > + $BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT >> $seqres.full
> > +
> > + $BTRFS_UTIL_PROG subvolume create $SCRATCH_MNT/a >> $seqres.full
> > + _ddt of="$SCRATCH_MNT"/a/file1 bs=1M count=1 >> $seqres.full 2>&1
> > + subvolid=$(_btrfs_get_subvolid $SCRATCH_MNT a)
> > + $BTRFS_UTIL_PROG subvolume snapshot -i 0/$subvolid $SCRATCH_MNT/a $SCRATCH_MNT/b >> $seqres.full
> > +
>
> Trailing whitespace in above line.
>
> > + _scratch_unmount
> > + _check_scratch_fs
>
> Trailing whitespace in above line.
>
> Otherwise looks fine.
>
> Thanks,
> Eryu
Thanks Eryu!
I've submitted a new patch for this.
Could you check it for me?
Thanks,
Sidong
>
> > +}
> > +
> > +
> > +assign_no_shared_test
> > +
> > +assign_shared_test
> > +
> > +snapshot_test
> > +
> > +# success, all done
> > +echo "Silence is golden"
> > +status=0
> > +exit
> > diff --git a/tests/btrfs/221.out b/tests/btrfs/221.out
> > new file mode 100644
> > index 00000000..aa4351cd
> > --- /dev/null
> > +++ b/tests/btrfs/221.out
> > @@ -0,0 +1,2 @@
> > +QA output created by 221
> > +Silence is golden
> > diff --git a/tests/btrfs/group b/tests/btrfs/group
> > index 1b5fa695..cdda38f3 100644
> > --- a/tests/btrfs/group
> > +++ b/tests/btrfs/group
> > @@ -222,3 +222,4 @@
> > 218 auto quick volume
> > 219 auto quick volume
> > 220 auto quick
> > +221 auto quick qgroup
> > --
> > 2.25.1
