On Fri, Sep 04, 2020 at 10:51:36AM +0300, Nikolay Borisov wrote: > > > On 4.09.20 г. 3:25 ч., Boris Burkov wrote: > > btrfs/131 covers a solid variety of free space tree scenarios, but it > > does not cover remount scenarios. We are adding remount support for read > > only btrfs filesystems to move to the free space tree, so add a few test > > cases covering that workflow as well. Refactor out some common free > > space tree code from btrfs/131 into common/btrfs. > > > > Signed-off-by: Boris Burkov <boris@xxxxxx> > > Generally LGTM, but I wonder if it would be beneficial to refer the > series which is supposed to make this test pass. If you look at other > patches in xfstest that's done in the header of the test i.e "This test > freespace remount behavior introduced by xxxx" and you refer to the name > of the patches (or alternatively the commit id if the patch has landed > upstream). Yes, mentioning the commit id or patch subject in either commit log or test description that makes the test pass is preferred. > > In any case: > > > Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx> Thanks for the review! Eryu
