Re: [PATCH] fstests: btrfs/218 check if mount opts are applied

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Aug 31, 2020 at 01:45:03PM +0200, David Sterba wrote:
> On Mon, Aug 31, 2020 at 12:15:19AM +0800, Eryu Guan wrote:
> > On Tue, Aug 04, 2020 at 05:56:48PM -0300, Marcos Paulo de Souza wrote:
> > > From: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> > > 
> > > This new test will apply different mount points and check if they were applied
> > > by reading /proc/self/mounts. Almost all available btrfs options are tested
> > > here, leaving only device=, which is tested in btrfs/125 and space_cache, tested
> > > in btrfs/131.
> > > 
> > > This test does not apply any workload after the fs is mounted, just checks is
> > > the option was set/unset correctly.
> > > 
> > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
> > 
> > I'm seeing this diff when testing with v5.9-rc2 kernel and v5.4
> > btrfs-progs, is that expected?
> > 
> >     +Could not find 'relatime,compress=lzo,space_cache,subvolid' in 'rw,relatime,compress=lzo:3,space_cache,subvolid=5,subvol=/', using 'compress=lzo'
> >     +Could not find 'relatime,compress=lzo,space_cache,subvolid' in 'rw,relatime,compress=lzo:3,space_cache,subvolid=5,subvol=/', using 'compress=lzo'
> >     +Could not find 'relatime,compress-force=lzo,space_cache,subvolid' in 'rw,relatime,compress-force=lzo:4,space_cache,subvolid=5,subvol=/', using 'compress-force=lzo'
> >     +Could not find 'relatime,compress-force=lzo,space_cache,subvolid' in 'rw,relatime,compress-force=lzo:4,space_cache,subvolid=5,subvol=/', using 'compress-force=lzo'
> >      Silence is golden
> 
> This should be fixed by 282dd7d77184 ("btrfs: reset compression level
> for lzo on remount") that is in v5.9-rc3.

Great!

Marcos, would you please refresh the patch to include the kernel fix in
commit log? Thanks!

Eryu



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux