> > > > > The test itself looks really good to me, my only concern is that > > > the updates in unionmount repo are not visible to fstests, and may cause > > > new failures, which are out of fstests' control. But I'm not sure if > > > this really is a problem for people. > > > > > > I came up with two options anyway > > > - add unionmount tests as a submodule of fstests > > > - put unionmount tests in fstests > > > > > > > I suppose you mean git submodule? > > Exactly. > > But I think I'd merge it as-is, git submodule brings more maintain > burden on both maintainers and users, especially users that usually > don't care about overlay tests. Users that care about overlay tests > should setup unionmount tests explicitly and know that's unionmount > tests if there's any test failure. > Great! I see you also kept my 100+N test numbering, which is very convenient :-) I have a patch on my dev branch to run unionmount test cases with metacopy enabled that Vivek requested. Will post it this week. Thanks! Amir.
